Speed up inspect and refresh Windows benchmarks#151
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (11 files)
Reviewed by kimi-k2.6-20260420 · Input: 77.7K · Output: 12.1K · Cached: 210.9K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inspectduplicate analysis opt-in with--duplicatesand reportduplicates.enablednpm run bench:docsregenerate the checked JSON and README table directlyWhy
inspectalways paid for duplicate extraction and candidate scoring even when callers only needed architecture summaries. It also missed the automatic native-worker policy already used by agent sessions.The checked documentation benchmark required a manual promotion step and still described an older WSL checkout, which made regeneration and interpretation unclear.
Impact
On this checkout, the warm-disk
inspectmedian improved from 11,515 ms to 7,505 ms when duplicate analysis became opt-in, then to 6,065 ms with automatic workers: about 47% overall.Duplicate summaries remain available through
inspect --duplicatesand the dedicatedduplicatescommand. Default inspect JSON now reports{ "duplicates": { "enabled": false } }.The regenerated Windows documentation benchmark reports cold one-shot
exploremedians of 461-523 ms with complete evidence anchors.Validation
npm run test:integration: 130 tests passednpm run bench:docs:checkgit diff --checknpm run check: lint, format, and build passed; the full test stage remains red on 24 Windows path/permission expectations outside this diff