Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize] enable primsjs runtime checker. #467

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nhsprite
Copy link
Collaborator

value passed across primjs runtime is not safe in lynx, it may cause many unexpected stability issues. in this commit, we upgrade primjs version to introduce runtime checker, it will detect the case value is passed across multiple runtimes.

the checker will be enable when devtool is enabled now, maybe we can add a platform interface for our users to enable the checker later.

issue: f-23957679047
AutoLand: true

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@nhsprite
Copy link
Collaborator Author

/land

@jianliang00
Copy link
Member

🛬 Landing process started! >>325.0

@jianliang00
Copy link
Member

🛬 Landing process started! >>326.0

@nhsprite
Copy link
Collaborator Author

/land

@jianliang00
Copy link
Member

🛬 Landing process started! >>332.0

@jianliang00
Copy link
Member

🛬 Landing process started! >>331.0

@nhsprite nhsprite force-pushed the p/nihao.royal/runtime-leak-checker branch from 1aa37b5 to 2368380 Compare March 24, 2025 05:54
@nhsprite
Copy link
Collaborator Author

/land

@jianliang00
Copy link
Member

🛬 Landing process started! >>333.0

@jianliang00
Copy link
Member

🛬 Landing process started! >>334.0

value passed across primjs runtime is not safe in lynx, it may cause many unexpected stability issues.
in this commit, we upgrade primjs version to introduce runtime checker, it will detect the case value is passed
across multiple runtimes.

the checker will be enable when devtool is enabled now, maybe we can add a platform interface for our users
to enable the checker later.

issue: f-23957679047
AutoLand: true
@nhsprite nhsprite force-pushed the p/nihao.royal/runtime-leak-checker branch from 2368380 to 9499cfc Compare March 30, 2025 14:30
@nhsprite
Copy link
Collaborator Author

/land

@jianliang00
Copy link
Member

🛬 Landing process started! >>358.0

@jianliang00
Copy link
Member

🛬 Landing process started! >>359.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants