Full rewrite

[iazel]

Hey there, thanks for publishing this plugin, it was of great inspiration for my work.

While playing around with it for my use case, I ended up doing a full rewrite. I believe this to be a better version, because:

• use Canvas API for the actual crop, thus removing the need for platform specific plugins. Now it runs everywhere.
• state is externalized in a controller, which makes it quite easy to test
• good test coverage
• crops images at a specific size
• impossible to alter crop area aspect ratio
• image doesn't need to be repositioned because we prevent image to become smaller than crop area and its edges to move inside the crop area. This behavior feels more natural to me.

Please let me know if you have any questions, hope you'd like it! :)

[creativecreatorormaybenot]

Hi there! I am not the author of the package. However, I suggest that you create your own new package for your rewrite.

This makes much more sense from both a maintenance and also a usage perspective. This will signal to users that this is a new, better package that has to be used differently.

Also, you will not have to wait for the maintainer to follow up.

[iazel]

Hi there! I am not the author of the package. However, I suggest that you create your own new package for your rewrite.

This makes much more sense from both a maintenance and also a usage perspective. This will signal to users that this is a new, better package that has to be used differently.

Also, you will not have to wait for the maintainer to follow up.

Yes, I thought about that too, but it comes with a bag of issues, like having to let people discover it. If the author likes the new version, then we all win because it will be a much smoother transition than finding a new library, and will better credit the effort they have invested in it so far :)

Also, right now I don't have much time to curate a new library, perhaps in the future I will properly publish it if this doesn't bring us anywhere.

Nonetheless, thanks for your point of view.

[lukehutch]

Hi @iazel, did you ever publish this anywhere?

Does your rewrite have the problem with Flutter 3.10 / Dart 3.0, mentioned in #106?

[lukehutch]

@iazel I tried your rewrite on Flutter 3.0.2, and I get this error:

: Error: The class 'Drag' can't be used as a mixin because it isn't a mixin class nor a mixin.
widgets.dart:68
    with TickerProviderStateMixin, Drag {
                                   ^

[iazel]

Hi @lukehutch , thanks for letting me know, I've updated this branch to work with Flutter 3.10. Let me know how it goes :)

About publishing as another package, I currently don't have much time to dedicate, but I may release it at the beginning of next year if @lykhonis don't want to merge it or doesn't respond

[lukehutch]

@iazel Can you please open the issue tracker on your repo? I have a few changes I may want to submit (e.g. I want to limit the crop region to a given minimum size -- currently only max zoom scale is supported as a constraint). It looks like I can submit PRs but not issues.

[iazel]

@lukehutch done, now it is possible to both create issues and discussions