Add parseraw function #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What actually needs to happen here is quite different. I'll take a crack at that later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We at Lyft are using this library to lint and perform operations on the AST of metricsql queries. This means we are roundtripping the queries from a source and back. For our usecase, we'd prefer to have a way to operate directly on the unoptimized parse tree. As an example, there are times where doing constant folding would write back a query that is less useful to a human.
To enable this use case, I've pulled out the core functionality of calling parseInternal, and evaluating the WITH expressions into a separate function.