Added mouse cursor auto-hiding to QTermWidget
#582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mouse cursor auto-hiding was implemented by @luebking: b150d85 Apart from adding mouse auto-hiding to `QTermWidget`, this patch fixes two issues of the above implementation: 1. `focusInEvent` and `focusOutEvent` weren't good for controlling auto-hiding, because the hidden mouse cursor can be near other widgets of the app (tab, menu-bar, …), in which case, it wasn't shown when put on them. Therefore, `enterEvent`, and `leaveEvent` are used instead. 2. The scrollbar needed a separate handling because it's a child of `TerminalDisplay`. NOTE: A related PR for QTerminal will follow this one.
tsujan
added a commit
to lxqt/qterminal
that referenced
this pull request
Feb 6, 2025
This patch needs lxqt/qtermwidget#582. The new option is in Preferences → Behavior. It can be from "Never" to 60 seconds. A value of zero hides the cursor immediately (as designed by @luebking). Closes #403
tsujan
added a commit
to lxqt/qterminal
that referenced
this pull request
Feb 7, 2025
This patch needs lxqt/qtermwidget#582. The new option is in Preferences → Behavior. It can be from "No hiding" to 60 seconds. A value of zero hides the cursor immediately (as designed by @luebking). Closes #403
tsujan
added a commit
to lxqt/qterminal
that referenced
this pull request
Feb 7, 2025
This patch needs lxqt/qtermwidget#582. The new option is in Preferences → Behavior. It can be from "No hiding" to 60 seconds. A value of zero hides the cursor immediately (as designed by @luebking). Closes #403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mouse cursor auto-hiding was implemented by @luebking: b150d85
Apart from adding mouse auto-hiding to
QTermWidget, this patch fixes two issues of the above implementation:focusInEventandfocusOutEventweren't good for controlling auto-hiding, because the hidden mouse cursor can be near other widgets of the app (tab, menu-bar, …), in which case, it wasn't shown when put on them. Therefore,enterEvent, andleaveEventare used instead.TerminalDisplay.NOTE: A related PR for QTerminal will follow this one.