Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LICENSE file #14

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Added LICENSE file #14

merged 7 commits into from
Sep 9, 2024

Conversation

stefonarch
Copy link
Member

Closes #13

@yan12125
Copy link
Member

Looks good, thanks!

@stefonarch
Copy link
Member Author

stefonarch commented Aug 29, 2024

Found another one to include and it looks like GNU General Public License v3.0 is better to include all the others, although they are not source code but configuration files mostly.

@yan12125 Can you recheck please?

@stefonarch
Copy link
Member Author

I got some inspiration also from here - that should be adressed too...
lxqt/lxqt-config#966

@yan12125
Copy link
Member

I'm not sure about "relicensed". I remember that happens only with permissions from the original author & contributors.

@stefonarch
Copy link
Member Author

stefonarch commented Aug 30, 2024

I'm not sure about "relicensed". I remember that happens only with permissions from the original author & contributors.

That would be we, the files based on lxqt-session. It looks like we can't include GPL3 otherwise, but as they are only config files I'm also not sure if this is really necessary, so we could turn also to the first version.

@yan12125
Copy link
Member

I believe configuration files should be properly licensed as well.

@stefonarch
Copy link
Member Author

I believe configuration files should be properly licensed as well.

They are, no?

@yan12125
Copy link
Member

yan12125 commented Sep 1, 2024

They are, no?

Yes, this is good. I was expressing my opinion about whether it is really necessary or not.

@stefonarch
Copy link
Member Author

Does this need any change now? Licensing isn't my field really.

@yan12125
Copy link
Member

yan12125 commented Sep 3, 2024

Probably not, but my spare time in September is quite limited. I may not be able to double check this soon.

@stefonarch
Copy link
Member Author

We could also use ef710a6 + the single license files added, it's probably less complex and will be fine the same IMO.

@yan12125
Copy link
Member

yan12125 commented Sep 5, 2024

We could also use ef710a6 + the single license files added, it's probably less complex and will be fine the same IMO.

Agreed - better to avoid relicensing stuff

@stefonarch
Copy link
Member Author

Done.
Not sure about the location of COPYING - put it both directories to which it applies?

@yan12125
Copy link
Member

yan12125 commented Sep 7, 2024

Thanks! Overall this looks good.

Not sure about the location of COPYING - put it both directories to which it applies?

Probably better to put all LICENSE-related files in the same place (ex: the top-level folder). I remember some projects are doing that, and I often check only one place for licenses.

@stefonarch
Copy link
Member Author

Probably better to put all LICENSE-related files in the same place

Done.

@yan12125 yan12125 merged commit 173f530 into master Sep 9, 2024
@yan12125 yan12125 deleted the add_license branch September 9, 2024 11:07
@yan12125
Copy link
Member

yan12125 commented Sep 9, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing for Linux distro packages
2 participants