-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LICENSE file #14
Conversation
Looks good, thanks! |
Found another one to include and it looks like GNU General Public License v3.0 is better to include all the others, although they are not source code but configuration files mostly. @yan12125 Can you recheck please? |
I got some inspiration also from here - that should be adressed too... |
I'm not sure about "relicensed". I remember that happens only with permissions from the original author & contributors. |
That would be we, the files based on lxqt-session. It looks like we can't include GPL3 otherwise, but as they are only config files I'm also not sure if this is really necessary, so we could turn also to the first version. |
I believe configuration files should be properly licensed as well. |
They are, no? |
Yes, this is good. I was expressing my opinion about whether it is really necessary or not. |
Does this need any change now? Licensing isn't my field really. |
Probably not, but my spare time in September is quite limited. I may not be able to double check this soon. |
We could also use ef710a6 + the single license files added, it's probably less complex and will be fine the same IMO. |
Agreed - better to avoid relicensing stuff |
Done. |
Thanks! Overall this looks good.
Probably better to put all LICENSE-related files in the same place (ex: the top-level folder). I remember some projects are doing that, and I often check only one place for licenses. |
Done. |
Thank you! |
Closes #13