Position LXTerminal according to the XOFF and YOFF parts of the argument to --geometry #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for libx11, even though it's already a dependency
Also make `geometry_columns` and `geometry_rows` unsigned integers, as `width` and `height` are unsigned integers in the `XParseGeometry` signature Note that the signs of `XOFF` and `YOFF` are independent of the signs in the geometry specification. The invocation `lxterminal --geometry=80x24+-100+-100` should position LXTerminal 100 pixels above and to the left of the top-left screen corner (i.e. off the screen).
Just store the bitmask returned by `XParseGeometry` in `CommandArguments` instead of multiple booleans
|
(Actually merged and pushed to git.lxde.org, then synced back to GitHub, but it seems pull request doesn't reflect to this) |
|
Also, this changeset reintroduces x11 dependency for geometry input parsing, though I think it is okay since current desktop environment may mostly have x11 as their dependency even Wayland is in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63