Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Labels Integration #151

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Nested Labels Integration #151

wants to merge 24 commits into from

Conversation

kozlov721
Copy link
Collaborator

@kozlov721 kozlov721 commented Jan 14, 2025

Integration of changes in luxonis-ml introduced in #211.

Config Changes

  • Field task in node configs renamed to task_name for naming consistency with luxonis-ml

Example
Let's have a dataset with 3 tasks; motorbike and car for detection, and vehicles for semantic segmentation. The labels would have the following keys:

{
    "motorbike/boundingbox",
    "motorbike/keypoints",
    "car/boundingbox",
    "car/keypoints",
    "vehicles/segmentation",
}

The following configuration for luxonis-train would make use of the above tasks:

model:
  name: parking_lot_model
  nodes:

    - name: EfficientRep

    - name: RepPANNeck

    - name: EfficientKeypointBBoxHead
      task_name: motorbike

    - name: EfficientKeypointBBoxHead
      task_name: car

    - name: SegmentationHead
      task_name: vehicles

@kozlov721 kozlov721 requested a review from a team as a code owner January 14, 2025 15:11
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team January 14, 2025 15:11
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request CLI Changes affecting the CLI labels Jan 14, 2025
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, left some comments

luxonis_train/config/config.py Outdated Show resolved Hide resolved
luxonis_train/loaders/luxonis_loader_torch.py Outdated Show resolved Hide resolved
luxonis_train/loaders/luxonis_loader_torch.py Show resolved Hide resolved
tests/integration/parking_lot.json Show resolved Hide resolved
Copy link
Member

@sokovninn sokovninn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JSabadin JSabadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Changes affecting the CLI documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants