feat: pass is_async to handler to return correct type of stream response #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
changed the title
Owner
|
Looks like a usable feature, will take a look, thanks |
lundberg
reviewed
May 21, 2025
respx/models.py
Outdated
| try: | ||
| # Call side effect | ||
| result: RouteResultTypes = effect(request, **kwargs) | ||
| result: RouteResultTypes = effect(request, is_async, **kwargs) |
Owner
There was a problem hiding this comment.
To be fully backwards compatible, and not force users to change their existing side effects, I think we could be graceful here and only pass is_async among kwargs if the implemented side effect specs it, i.e. like the route kwarg is handled above.
e.g.
if "is_async" in argspec.args:
kwargs["is_async"] = is_async.. maybe handle both spec'ed as arg or kwarg 🤔
lundberg
reviewed
May 22, 2025
Co-authored-by: Jonas Lundberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it's impossible to create generic stream response for the same endpoint for both sync and async cases.
ref: #156 (comment)