Skip to content

Remove re-export of thiserror #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

Remove re-export of thiserror #53

merged 1 commit into from
May 18, 2025

Conversation

Kitt3120
Copy link
Contributor

Re-exporting thiserror is no longer supported by the upstream crate.

See dtolnay/thiserror#386 for more.

@Kitt3120 Kitt3120 self-assigned this May 18, 2025
@Copilot Copilot AI review requested due to automatic review settings May 18, 2025 14:17
@Kitt3120 Kitt3120 added this to Lum May 18, 2025
@Kitt3120 Kitt3120 added the dependencies Pull requests that update a dependency file label May 18, 2025
@github-project-automation github-project-automation bot moved this to Todo in Lum May 18, 2025
@Kitt3120 Kitt3120 moved this from Todo to In review in Lum May 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unsupported re-export of thiserror from the crate’s public interface and its direct dependency since upstream no longer supports it.

  • Drop pub use thiserror from src/lib.rs
  • Remove thiserror from Cargo.toml dependencies

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/lib.rs Removed pub use thiserror re-export
Cargo.toml Deleted thiserror = "2.0.12" dependency

@Kitt3120 Kitt3120 merged commit 6a3b61c into main May 18, 2025
4 checks passed
@Kitt3120 Kitt3120 deleted the fix/remove-thiserror branch May 18, 2025 14:18
@github-project-automation github-project-automation bot moved this from In review to Done in Lum May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant