Skip to content

Safer parsing of icons from info.plist #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Safer parsing of icons from info.plist #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/beta_builder/archived_build.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,28 @@ def save_to(path)

private

def ios5_style_icon_paths
return nil if metadata['CFBundleIcons'].nil?
metadata['CFBundleIcons']['CFBundlePrimaryIcon']['CFBundleIconFiles']
end

def generic_icon_paths
metadata['CFBundleIconFiles']
end

def icon_paths
paths = ios5_style_icon_paths || generic_icon_paths || []
paths.map {|file| File.join("Applications", @configuration.app_file_name, file) }
end

def write_plist_to(path)
version = metadata["CFBundleShortVersionString"] || metadata["CFBundleVersion"]
plist = {
"ApplicationProperties" => {
"ApplicationPath" => File.join("Applications", @configuration.app_file_name),
"CFBundleIdentifier" => metadata["CFBundleIdentifier"],
"CFBundleShortVersionString" => version,
"IconPaths" => metadata["CFBundleIconFiles"].map { |file| File.join("Applications", @configuration.app_file_name, file) }
"IconPaths" => icon_paths
},
"ArchiveVersion" => 1.0,
"Comment" => @configuration.release_notes_text,
Expand Down