Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for setting drawer width on landscape #50

Merged
merged 3 commits into from
Mar 5, 2022

Conversation

Danite
Copy link

@Danite Danite commented Jul 20, 2021

Addressed issue-> #44

I created a new prop for controlling the width of the drawer on landscape orientation. I guess a better approach could have been controlling the width via an object prop, but I didn't want to make drastic changes to the API.

CC: @lukebrandonfarrell

Copy link
Contributor

@rodriigovieira rodriigovieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

README.md Outdated Show resolved Hide resolved
@lukebrandonfarrell
Copy link
Owner

Nice job @Danite will review this week, and get back with feedback or merge

@Danite
Copy link
Author

Danite commented Aug 3, 2021

@lukebrandonfarrell @rodriigovieira Updated the docs!

@lukebrandonfarrell
Copy link
Owner

lukebrandonfarrell commented Aug 8, 2021

Hey @Danite, solid improvement! Could you let me know why direction is typed as optional i.e. direction? (?). Other than that this looks good. Have you tested this on non-landscape mode to make sure it doesn't break anything?

Let me know the above, then I'll merge this in!

Thanks for the contribution.

PS. Ignore below, was having a fight with the all-contributors bot lol

@allcontributors

This comment has been minimized.

@lukebrandonfarrell
Copy link
Owner

@all-contributors add @Danite for code and docs

@allcontributors
Copy link
Contributor

@lukebrandonfarrell

I've put up a pull request to add @Danite! 🎉

@lukebrandonfarrell

This comment has been minimized.

@allcontributors

This comment has been minimized.

@lukebrandonfarrell

This comment has been minimized.

@allcontributors

This comment has been minimized.

@lukebrandonfarrell

This comment has been minimized.

@allcontributors

This comment has been minimized.

@lukebrandonfarrell

This comment has been minimized.

@allcontributors

This comment has been minimized.

@lukebrandonfarrell
Copy link
Owner

@Danite ?

@lukebrandonfarrell
Copy link
Owner

@Danite are you there?

@lukebrandonfarrell
Copy link
Owner

@Danite this was almost over the line, I'll send this last message, let me know if it can be picked back up, if not I'll close this. Thanks

@Danite
Copy link
Author

Danite commented Feb 24, 2022

@lukebrandonfarrell Sorry about that, I forgot about this pull request, and I thought it was already merged. I'll resolve the conflicts and verify that it's working correctly.

About the question of why did I change direction to be optional, If I remember correctly, It was because it had a default prop value set to "left"

@lukebrandonfarrell
Copy link
Owner

@Danite Sounds good! If you can resolve the conflicts I'm happy to merge this and release

@Danite
Copy link
Author

Danite commented Feb 24, 2022

@lukebrandonfarrell I solved the conflict and check that everything is working properly. When I did the commit, the pre-commit ran the prettier and changed some lines. If it too many changes I could do a revert and create a commit without verification.

@lukebrandonfarrell
Copy link
Owner

Looks good to me @Danite, merging :)

@lukebrandonfarrell lukebrandonfarrell merged commit c3b80eb into lukebrandonfarrell:master Mar 5, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants