-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for setting drawer width on landscape #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Nice job @Danite will review this week, and get back with feedback or merge |
@lukebrandonfarrell @rodriigovieira Updated the docs! |
Hey @Danite, solid improvement! Could you let me know why Let me know the above, then I'll merge this in! Thanks for the contribution. PS. Ignore below, was having a fight with the all-contributors bot lol |
This comment has been minimized.
This comment has been minimized.
@all-contributors add @Danite for code and docs |
I've put up a pull request to add @Danite! 🎉 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@Danite ? |
@Danite are you there? |
@Danite this was almost over the line, I'll send this last message, let me know if it can be picked back up, if not I'll close this. Thanks |
@lukebrandonfarrell Sorry about that, I forgot about this pull request, and I thought it was already merged. I'll resolve the conflicts and verify that it's working correctly. About the question of why did I change |
@Danite Sounds good! If you can resolve the conflicts I'm happy to merge this and release |
@lukebrandonfarrell I solved the conflict and check that everything is working properly. When I did the commit, the pre-commit ran the prettier and changed some lines. If it too many changes I could do a revert and create a commit without verification. |
Looks good to me @Danite, merging :) |
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Addressed issue-> #44
I created a new prop for controlling the width of the drawer on landscape orientation. I guess a better approach could have been controlling the width via an object prop, but I didn't want to make drastic changes to the API.
CC: @lukebrandonfarrell