Skip to content

Conversation

@lyj0309
Copy link

@lyj0309 lyj0309 commented Jan 1, 2025

No description provided.

Copy link
Collaborator

@hasecilu hasecilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I seems like a good addition to me despite not having some kind of filetype, it's a relevant project.

Regarding the SVG, could you upload it as a single object (merge all paths into a single one) with black color in a square canvas.

@lyj0309 lyj0309 requested a review from hasecilu January 3, 2025 06:24
@lyj0309
Copy link
Author

lyj0309 commented Jan 3, 2025

ok, i updated svg as your request

Copy link
Collaborator

@hasecilu hasecilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good

@hasecilu
Copy link
Collaborator

hasecilu commented Jan 6, 2025

Hi @Finii, I think we could make a release before NF in order to include this logo, what do you think? For the moment I don't have ant other logo planned though.

@Finii
Copy link
Collaborator

Finii commented Jan 6, 2025

@hasecilu Happy new year ;-)

Sure! Not sure about the NF release date though. There's not much yet (I believe 🤔 ) apart from the Devicons that I would not have merged here in their form (quality wise). Ended up now to hand-inspect all 500 icons :-(
Any opinion on the NF schedule? 😀

@hasecilu
Copy link
Collaborator

hasecilu commented Jan 8, 2025

Hey, happy new year! 🎉

I think there is no hurry to release soon, I just wanted to make sure that any changes made here arrive to next version. I have seen that people doesn't seem to update right away and even some weeks can pass.

@Finii
Copy link
Collaborator

Finii commented Jan 15, 2025

The svg

  • has a lot cruft in it (i.e. unneeded comments and properties)
  • it uses transform which sometimes confuses fontforge, recommend applying it instead of describing.
  • I'm not sure the clip path is interpreted by fontforge at all, I would work that into the real path instead.
    See no reason why such a simple outline would need a clipbath at all 🤔 That must be some manual cleanup leftover?

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants