-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Python 3.10, 3.11, 3.12 compatibility #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Dear @mhabedank and @ethanreidel, First of all, thank you both for the excellent work on PR #4041! I've carefully studied your technical approach, and I'm impressed by how well-designed the tokenizer refactoring is. I've recently tested these tokenizer changes in my environment and found they work beautifully. I was wondering if I could contribute some test validation results to help move this PR forward. I'd be happy to assist in whatever way works best for you: Option A: If it's convenient, you could add me as a collaborator
Option B: I can submit PRs to your branch
Here's what I've already completed:
I noticed the CI shows "0 tests executed"—I'm not sure if it's a configuration issue, but if needed, I'd be happy to help with test-related setup as well. My intention is purely to help this PR move forward—I have absolutely no desire to take credit or compete. If you don't need additional help or have other considerations, I completely understand and respect that. Thank you again for your hard work! I look forward to potentially collaborating. Best regards, |
This PR tries to solve the dependency problems we have when going forward to modern Python version.
Things currently done: