Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nx-python): update README #177

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

busla
Copy link

@busla busla commented Oct 20, 2023

Update README with example

I think this plugin has a lot of potential given that developing non-js plugins is a complex task, well done 💪🏼

I thought I'd start adding a PR with configuration examples but perhaps it's better to just add a single example for now and get feedback on how (and if) you would like a chapter per target with json config examples.

I can then add some more.

@busla
Copy link
Author

busla commented Oct 20, 2023

I am noticing that package-lock.json was modified, that is weird 🤷🏼

Perhaps pinning node and npm versions in package.json might help.

Here is my env:

# nx --version
Nx Version:
- Local: v16.3.2
- Global: Not found

# npm --version
9.6.7

# node --version
v18.17.1

@@ -7301,6 +7302,7 @@
"resolved": "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-1.1.7.tgz",
"integrity": "sha512-nxwy40TuMiUGqMyRHgCSWZ9FM4VAoRP4xUYSTv5ImRog+h9yISPbVH7H8fASCIzYn9wlEv4zvFL7uKDMCFQm3g==",
"dev": true,
"optional": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to this project, sorry for the delay, could you please revert the changes in this file? since you just changed the readme, I don't think the package-lock.json should be part of this PR.

Thanks!

@lucasvieirasilva
Copy link
Owner

I am noticing that package-lock.json was modified, that is weird 🤷🏼

Perhaps pinning node and npm versions in package.json might help.

Here is my env:

# nx --version
Nx Version:
- Local: v16.3.2
- Global: Not found

# npm --version
9.6.7

# node --version
v18.17.1

Yep, that's weird, you should use npm ci instead of npm install when you have any intention of adding, changing, or removing any package from the project.

@busla busla marked this pull request as draft October 30, 2023 09:21
@busla
Copy link
Author

busla commented Oct 30, 2023

I converted the PR to a draft since it's actually an issue. The package-lock got modified by running npm install, which it shouldn't, so I guess it will get modified whenever anyone clones it and runs npm install 🤷.

@lucasvieirasilva
Copy link
Owner

I guess it will get modified whene

Yes, you're right, let me raise a PR to fix this and I'll let you know.

@lucasvieirasilva
Copy link
Owner

@busla I've updated the package-lock.json, could you merge the latest changes in the main branch with your branch and see if the package-lock changes are now synced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants