-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(nx-python): update README #177
base: main
Are you sure you want to change the base?
Conversation
I am noticing that Perhaps pinning Here is my env: # nx --version
Nx Version:
- Local: v16.3.2
- Global: Not found
# npm --version
9.6.7
# node --version
v18.17.1 |
@@ -7301,6 +7302,7 @@ | |||
"resolved": "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-1.1.7.tgz", | |||
"integrity": "sha512-nxwy40TuMiUGqMyRHgCSWZ9FM4VAoRP4xUYSTv5ImRog+h9yISPbVH7H8fASCIzYn9wlEv4zvFL7uKDMCFQm3g==", | |||
"dev": true, | |||
"optional": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to this project, sorry for the delay, could you please revert the changes in this file? since you just changed the readme, I don't think the package-lock.json should be part of this PR.
Thanks!
Yep, that's weird, you should use |
I converted the PR to a draft since it's actually an issue. The package-lock got modified by running |
Yes, you're right, let me raise a PR to fix this and I'll let you know. |
@busla I've updated the package-lock.json, could you merge the latest changes in the |
Update README with example
I think this plugin has a lot of potential given that developing non-js plugins is a complex task, well done 💪🏼
I thought I'd start adding a PR with configuration examples but perhaps it's better to just add a single example for now and get feedback on how (and if) you would like a chapter per target with
json
config examples.I can then add some more.