fix type for notificationIDList in _build_monitor_data() #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type here is incorrect. In
_build_monitor_data()
, thenotificationIDList
parameter is alist
, which then gets converted to adict
in_convert_monitor_input()
.The wrong type here doesn't actually affect anything as it is an empty
dict
and thus never processed in_convert_monitor_input()
, as an emptylist
would have been as well.But it's still technically the wrong type in that part of the code, and changing other parts of the code could result in that causing a bug at some point.
NB: I haven't tested this change yet.