Skip to content

Conversation

@vrn-sn
Copy link
Member

@vrn-sn vrn-sn commented Oct 10, 2025

No description provided.

@vrn-sn vrn-sn requested a review from skanosue October 10, 2025 21:34
@vrn-sn
Copy link
Member Author

vrn-sn commented Oct 10, 2025

@skanosue recent commit changes the bad error message to something maybe a bit better

Old:

> lute varun_test/requirer.luau incorrect_path
error requiring module "@self": could not reset to requiring context
stacktrace:
[C] function proxyrequire
[C] function requirefromcwd
./varun_test/requirer.luau:5

New:

> lutedebug varun_test/requirer.luau incorrect_path            
./varun_test/requirer.luau:5: file not found: /Users/vsaini/git/lute/incorrect_path
stacktrace:
[C] function requirefromcwd
./varun_test/requirer.luau:5

@vrn-sn
Copy link
Member Author

vrn-sn commented Oct 10, 2025

@skanosue if we want to support requiring an absolute path directly like I did in this draft, requirepath might be a better name (still keeping requirefrompath for the other API we've talked about, nice symmetry there).

Otherwise, we could just error on absolute paths like require does and keep this one named requirefromcwd.

@vrn-sn vrn-sn assigned vrn-sn and skanosue and unassigned vrn-sn Oct 11, 2025
@vrn-sn vrn-sn closed this Oct 21, 2025
@vrn-sn vrn-sn deleted the vrn-sn/requirefromcwd-experiment branch October 21, 2025 21:01
@vrn-sn
Copy link
Member Author

vrn-sn commented Oct 21, 2025

Superseded by #461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants