Fix missing direct includes - #2687
Open
Aesthete wants to merge 4 commits into
Open
Conversation
vegorov-rbx
reviewed
Aug 21, 2026
vegorov-rbx
reviewed
Aug 21, 2026
vegorov-rbx
reviewed
Aug 21, 2026
vegorov-rbx
reviewed
Aug 21, 2026
vegorov-rbx
reviewed
Aug 21, 2026
vegorov-rbx
reviewed
Aug 21, 2026
vegorov-rbx
reviewed
Aug 21, 2026
|
In libc++ 23, removing transitive includes became the default, and in libc++ 24 it will be mandatory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Embedding Luau in a project that disables libc++ transitive includes fails to compile because several Luau files use declarations without including the headers that define them.
Reproduced on Linux with Clang 21.1.8, libc++ 21.1.8, C++17, and:
Example errors include undeclared
abs,malloc,atoi,strtoull,errno,getenv,free, andexit.ConditionA64.husesCODEGEN_ASSERT, defined inCodeGenCommon.h. It's unrelated to the libc includes but it's also not IWYU and appeared during testing.Fix
Add the required direct includes.
Tests
Luau.UnitTest,Luau.Conformance, andLuau.CLI.Testpass with the same flags.