Improve "block too big" errors - #2579
Open
PhoenixWhitefire wants to merge 9 commits into
Open
Conversation
PhoenixWhitefire
marked this pull request as ready for review
July 22, 2026 16:43
PhoenixWhitefire
changed the title
|
Should also include the max allowed size of the type in the err message |
PhoenixWhitefire
marked this pull request as draft
July 24, 2026 02:00
PhoenixWhitefire
marked this pull request as ready for review
July 24, 2026 07:31
vegorov-rbx
reviewed
Aug 4, 2026
| { | ||
| if (s > MAX_BUFFER_SIZE) | ||
| luaM_toobig(L); | ||
| luaM_toobig(L, "buffer too big (exceeds maximum of 1GiB)"); |
Collaborator
There was a problem hiding this comment.
Don't include the size in the message.
Collaborator
There was a problem hiding this comment.
Unnecessary maintenance burden, limits can be looked up in documentation of a particular runtime.
Contributor
Author
There was a problem hiding this comment.
Could it be part of the format arguments for luaM_toobig - "memory allocation error: %s (exceeds maximum of %zi bytes)" with MAXSSIZE, INT_MAX - sizeof(Udata) being passed etc?
vegorov-rbx
reviewed
Aug 4, 2026
vegorov-rbx
reviewed
Aug 4, 2026
vegorov-rbx
reviewed
Aug 4, 2026
This reverts commit 15fdcc6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will now be "memory allocation error: [string/buffer/userdata] too big (exceeds maximum of X bytes)" when applicable