Fix frozen string literal mutation#1626
Closed
viralpraxis wants to merge 1 commit intolsegal:mainfrom
Closed
Conversation
There's a warning ```shell ruby_lex.rb:987: warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information ``` which will lead to an error when frozen strings literals (MRI 3.5?) will be frozen by default.
viralpraxis
force-pushed
the
fix-frozen-string-literal-mutation
branch
from
5915717 to
984f82f
Compare
Owner
|
Getting to this pretty late but seems like this would break encoding support in YARD. |
Owner
|
Fixed by c92f02a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a warning
which will lead to an error when frozen strings literals (MRI 3.5?) will be frozen by default.
Description
Describe your pull request and problem statement here.
Completed Tasks
bundle exec rakelocally (if code is attached to PR).