fix: pass Godot's bin dir to relay for PATH resolution in GUI launches#7
Open
Walkercito wants to merge 2 commits into
Open
fix: pass Godot's bin dir to relay for PATH resolution in GUI launches#7Walkercito wants to merge 2 commits into
Walkercito wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Godot is launched from a desktop entry (not a terminal), the relay process fails to find
nodebecause PATH doesn't include version managers like NVM/fnm/volta/asdf. (Issue in Linux-like Systems)Solution
_which()to fall back to login+interactive shell (runs profile scripts) and scan common install locations (~/.volta/bin,~/.asdf/shims,~/.local/bin, NVM/fnm versions)Testing
Tested by launching Godot from desktop entry with NVM/fnm installed in Ubuntu 24 LTS