Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dv] Change TLUL references to Address and Data channels into A and D #26519

Open
martin-velay opened this issue Mar 5, 2025 · 2 comments · May be fixed by #26796
Open

[dv] Change TLUL references to Address and Data channels into A and D #26519

martin-velay opened this issue Mar 5, 2025 · 2 comments · May be fixed by #26796
Labels
Component:DV DV issue: testbench, test case, etc.

Comments

@martin-velay
Copy link
Contributor

Address and Data channels don't exist in the TL spec. There is a confusion as TileLink defines 5 channels called A, B, C, D and E. For TLUL version, only A and D are used, but A doesn't stand for Address and D is not for Data.

This will probably be a significant task as many (probably all) IPs are referring to these confusing words. Please also note that the gen.py and related scripts will also need to be changed.
@martin-velay
Copy link
Contributor Author

FYI, I have created an issue to track this
@rswarbrick, @antmarzam, @hcallahan-lowrisc, @marcelocarvalhoLowRisc and @KinzaQamar

@martin-velay martin-velay added the Component:DV DV issue: testbench, test case, etc. label Mar 5, 2025
@hcallahan-lowrisc
Copy link
Contributor

Thanks for creating the issue. This has bugged me for a long time, but as you rightly point out it will probably be a significant task to fix across all the templates/comments/scripts etc.

martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 7, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
c2da88c 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 10, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
40d1186 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 12, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
f4ab61c 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 12, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
89f534b 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 12, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
07f869f 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 14, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
310c07d 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 19, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
15b4b11 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 19, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
0a88a0e 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
martin-velay added a commit to martin-velay/opentitan that referenced this issue Mar 19, 2025
@martin-velay
[acrc,dv] Clarify A and D channels for TLUL in SCB
1cdb060 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
rswarbrick pushed a commit that referenced this issue Mar 20, 2025
@martin-velay @rswarbrick
[acrc,dv] Clarify A and D channels for TLUL in SCB
4811d19 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future #26519.

Signed-off-by: Martin Velay <[email protected]>
vogelpi pushed a commit to vogelpi/opentitan that referenced this issue Mar 21, 2025
@martin-velay @vogelpi
[acrc,dv] Clarify A and D channels for TLUL in SCB
e5e09c3 
- AddrChannel and DataChannel don't exist in the TL spec. There is a
  confusion as TileLink defines 5 channels called A, B, C, D and E.
  For TLUL version, only A and D are used, but A is not for Address
  and D is not for Data.
- The remaining refferences cannot be changed as this is depending on
  the TL common code and requires many changes in different places. An
  issue has been created to track this in the future lowRISC#26519.

Signed-off-by: Martin Velay <[email protected]>
@rswarbrick rswarbrick linked a pull request Mar 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component:DV DV issue: testbench, test case, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rtl] Avoid Addr/Data channel misnaming rswarbrick/opentitan
2 participants
@hcallahan-lowrisc @martin-velay