Skip to content

Allow hash comments in assembly files (.S, .s)#31

Open
colluca wants to merge 1 commit intolowRISC:masterfrom
colluca:assembly-hash-comments
Open

Allow hash comments in assembly files (.S, .s)#31
colluca wants to merge 1 commit intolowRISC:masterfrom
colluca:assembly-hash-comments

Conversation

@colluca
Copy link

@colluca colluca commented Apr 19, 2023

No description provided.

@rswarbrick
Copy link
Contributor

Hmm, I'm afraid I don't understand why we want to do this. Are you thinking of some version of assembly where I can add # foo bar baz to a file without it doing anything? I don't think this is universally supported, and I've not actually seen assembly written in that style.

What does the change fix for you?

@colluca
Copy link
Author

colluca commented Apr 20, 2023

This article lists at least two additional styles to the ones currently supported, i.e. comments starting with a hash and comments starting with a semicolon:
https://en.wikibooks.org/wiki/X86_Assembly/Comments

The RISC-V assembler also supports comments starting with a hash. My particular use-case is within the Snitch core repository:
https://github.com/pulp-platform/snitch/blob/master/sw/snRuntime/src/start.S

Possibly, this feature request #9 could also solve the problem for me without having to hardcode any new comment styles in the tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants