Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux arm64.AppImage #2154

Merged
merged 18 commits into from
Feb 18, 2025
Merged

Linux arm64.AppImage #2154

merged 18 commits into from
Feb 18, 2025

Conversation

humbertodias
Copy link
Contributor

@humbertodias humbertodias commented Feb 17, 2025 •
edited
Loading

Changes

@humbertodias humbertodias mentioned this pull request Feb 17, 2025
Closed
@MikuAuahDark
Copy link
Contributor

Does this actually build for ARM64?

MikuAuahDark
MikuAuahDark requested changes Feb 17, 2025
View reviewed changes
@MikuAuahDark
Copy link
Contributor

Further inspection, looks like vulkan-sdk package is not available for ARM64 right now (https://vulkan.lunarg.com/issue/view/5a7b54796631511d3732aabb). I'll put this PR on-hold until we know how we should decide on the Vulkan tests.

@slime73
Copy link
Member

slime73 commented Feb 17, 2025

Can we make CI build the SDK, similar to the latest comment in that issue report?

@humbertodias
Copy link
Contributor Author

Does this actually build for ARM64?

Yes, I have successfully tested it now.
love2d-linux-arm64

love-linux-ARM64.AppImage.zip

slime73
slime73 requested changes Feb 17, 2025
View reviewed changes
@humbertodias humbertodias requested a review from slime73 February 17, 2025 21:56
MikuAuahDark
MikuAuahDark requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@MikuAuahDark MikuAuahDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor changes remaining.

Unfortunately I cannot test if the resulting ARM64 binary run in my Raspberry Pi 5 because it runs Debian 12 (which has older glibc than Ubuntu 24.04) but I'll trust the resulting binary.

@MikuAuahDark MikuAuahDark merged commit 1462bd4 into love2d:main Feb 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slime73 slime73 slime73 approved these changes

@MikuAuahDark MikuAuahDark MikuAuahDark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humbertodias @MikuAuahDark @slime73