Selector buttons #200
Merged
Selector buttons #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, and very useful! I'd like to merge #195 first, then we'll merge this. |
element.getCTM() returns `null` if one of the transformation matrices is zero. This fix uses get_transform_matrix instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds buttons on the selection box to delete, duplicate and scale the selected elements.
It currently looks like this:
Here is a video demo:
https://user-images.githubusercontent.com/26575793/120487928-a84cc600-c3b6-11eb-812b-23485410ce04.mp4
It also includes keybindings
dfor duplication anddeletefor deleting the selection.Internally the PR replaces the deltax and deltay attributes in a message with the transform attribute, containing a transformation matrix. Also it adds a new message type
copy. This message contains anidanewid, and copies the object with the ididto an object with idnewid.I tried to make this PR IE9 compatible, but since I work on linux I could not test the compatibility.
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.The PR also includes a commit making the changes in #193 IE9 compatible (or so I hope). If you would rather have these fixes in a separate PR please tell me and I will open a new PR.