Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Git and Smart-Enter plugins #27

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

NickHackford
Copy link

@NickHackford NickHackford commented Mar 20, 2025

Reopening
#22

I'm on darwin and this repo works for me so I added it to the systems.

I didn't do the require change because I didn't understand it and didn't have time to figure out how it works now. I use custom lua by editing the initLua attribute and it worked just fine for me. My yazi.lua includes all the requires and my custom lua.

If you leave a suggestion on what I need to change I can do it but it seemed complicated for string concatenation.

Nick Hackford added 3 commits March 20, 2025 09:49
Copy link
Collaborator

@haennes haennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise. Will test soon hopefully

@@ -62,7 +62,7 @@
imports = (
filter (v: v != { }) [
(
inputs:
{ pkgs, ... }@inputs:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does anyone have an idea, why this is neccesarry?

@haennes haennes requested a review from lordkekz March 23, 2025 19:34
@haennes
Copy link
Collaborator

haennes commented Mar 23, 2025

succesfully tested this locally

@haennes haennes self-requested a review March 23, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants