Remove unreferenced assets - #795
Open
rwojsznis wants to merge 1 commit into
Open
Conversation
Those asses are part of gem which bloats its size a bit. Ideally `build`` command should do initial cleanup of public folder - but that's out of scope of this PR.
✅ Deploy Preview for lookbook-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those asses are part of gem which bloats its size a bit.
Ideally
buildcommand should do initial cleanup of public folder - but that's out of scope of this PR.Hey there 👋 as per comment - seems like some lost assets are part of the gem - noticed this as I was looking way to shave some MBs of my CI gemfile cache ;)
after the change:
I'm also unsure about sourcemaps which are generated for both js and css files - maybe those should/could be yanked as well?