Add ability to disable resizing of the window #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huacnlee
requested changes
Nov 9, 2025
Member
huacnlee
left a comment
huacnlee
left a comment
There was a problem hiding this comment.
We shouldn't add this; it seems we can simply check whether the current window allows resizing within the WindowBorder.
Member
|
I checked the GPUI window, and it doesn't seem to have anything related to it. However, your current modification still doesn't work; it only addresses the Linux limitation. I think this requirement should be addressed by adding this parameter to the GPUI side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to disable window resizing in gpui-component.
It would be nice if gpui-component inherited
is_resizablefromWindowOptions, but AFAIK, there is no way to access that value of the window after window creation, so I added the resizable option toRoot(andWindowBorder) instead, withtrueas the default value to maintain the current behavior when unset.If you are unhappy with the API in the PR, but agree that resizing should be something that can be disabled, then treat this as a feature request.