fix(core): prevent account enumeration and spam during password reset#8375
Open
boazy wants to merge 1 commit intologto-io:masterfrom
Open
fix(core): prevent account enumeration and spam during password reset#8375boazy wants to merge 1 commit intologto-io:masterfrom
boazy wants to merge 1 commit intologto-io:masterfrom
Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/routes/experience/verification-routes/verification-code-helpers.ts | 📈 +506 Bytes |
| packages/core/src/routes/experience/verification-routes/verification-code.ts | 📈 +34 Bytes |
| packages/core/src/routes/interaction/additional.ts | 📈 +707 Bytes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two security and operational issues in the password reset flow:
Changes:
additionalRoutesand Experience APIsendCodehelper.ForgotPasswordevents, if the user doesn't exist, we skip sending the message but still return204 No Content.userExists: false) for these non-delivery attempts to help identify potential enumeration attacks.