Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hpm installation instructions under versioned #431

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

neogopher
Copy link
Contributor

Content Description

Updated the docs for current and previous version (v0.21 & v0.22) to include detailed installation instructions for hpm.

Preview Link

Internal Reference

Closes DOC-393

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for vcluster-docs-site ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f3f9993
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/6790e87d59a47300083c2c78
😎 Deploy Preview https://deploy-preview-431--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@neogopher neogopher requested a review from a team January 22, 2025 12:53
@cbron cbron requested a review from sowmyav27 January 22, 2025 23:53
Copy link

@cbron cbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more addition, otherwise seems fine. Would bring new docs in line with old ones.

--repo https://charts.loft.sh \
-n my-namespace \
--set VclusterReleaseName=my-vcluster
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the version split here: https://github.com/loft-sh/vcluster-hostpath-mapper/pull/23/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R39

I think instead of adding a support matrix everywhere, you could just add a note to the 0.20 docs that they can't use anything above 0.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants