Spark 3.5: Fix StaticInvoke constructor differences in ManualTypedEncoder; add tests; fixes #630 #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for the contribution! We'll take a look once have sometime. Could you also sign ECA please to make Eclipse license checker happy? |
anudeepkonaboina-db
force-pushed
the
fix/spark-3.5-staticinvoke
branch
from
feba794 to
5054956
Compare
|
Done @pomadchin ! |
…; deterministic + arg types; fallback to constructor. Add test. Signed-off-by: anudeepkonaboina-db <[email protected]> Signed-off-by: AnudeepKonaboina <[email protected]>
anudeepkonaboina-db
force-pushed
the
fix/spark-3.5-staticinvoke
branch
from
5054956 to
ccb41f8
Compare
|
Hey @pomadchin! I'm sorry. I created a PR with the wrong account. I have created a new one with teh right account. Sorry for the confusion. New PR: #632 |
|
closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Spark 3.5 changed org.apache.spark.sql.catalyst.expressions.objects.StaticInvoke constructor shape, breaking reflective construction used by encoders.
Solution:
Build StaticInvoke reflectively by selecting the max-arity constructor (8/9 args) and trying both target class and companion module (static forwarder) for apply. Fallback to NewInstance when no static forwarder matches arity. Compatible with Spark 3.4 and 3.5.
Added:
ManualTypedEncoderSpec ensuring case-class decoding via static apply works through ManualTypedEncoder.staticInvoke.
Fixes: #630.