Add KdTree nearestNeighbor() and nearestNeighbors() #1114
Conversation
micycle1
changed the title
modules/core/src/test/java/org/locationtech/jts/index/kdtree/KdTreeTest.java
Outdated
Show resolved
Hide resolved
| * @param n the number of nearest nodes to find | ||
| * @return a list of the nearest nodes, sorted by distance (closest first), or an empty list if the tree is empty. | ||
| */ | ||
| public List<KdNode> nearestNeighbors(final Coordinate query, final int n) { |
There was a problem hiding this comment.
These method names are different to the ones on STRtree - e.g. it has nearestNeighbourK. But I prefer this naming style. Perhaps STRtree should add methods with these names and deprecate the old ones.
There was a problem hiding this comment.
Are you suggesting to do that in this PR?
There was a problem hiding this comment.
No, they can be added in a future PR.
There was a problem hiding this comment.
Ok, ready for merge then I think.
| testNearestNeighborsPerformance(); | ||
| } | ||
|
|
||
| private void testNearestNeighborsPerformance() { |
There was a problem hiding this comment.
This should really be in a separate file KdtreePerfTest. Ideally it would use the performance test framework (see example). But it's ok to keep the current code structure for now.
There was a problem hiding this comment.
@micycle1 are you able to split the performance test code out into a separate class?
Implement #758.
added a
getNodes()too, and a few other minor touch ups.