Skip to content

Conversation

@arvinxx
Copy link
Member

@arvinxx arvinxx commented Nov 2, 2025

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

📸 Screenshots / Videos

Before After
... ...

📝 Additional Information

@vercel
Copy link

vercel bot commented Nov 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lobehub Ready Ready Preview Comment Nov 3, 2025 2:04am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
lobehub-lite Ignored Ignored Preview Nov 3, 2025 2:04am

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @arvinxx, your pull request is larger than the review limit of 150000 diff characters

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 2, 2025
@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.

@gru-agent
Copy link
Contributor

gru-agent bot commented Nov 2, 2025

There is too much information in the pull request to test.

@dosubot dosubot bot added the Model Provider Model provider related label Nov 2, 2025
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.70%. Comparing base (4363f7d) to head (7089c19).
⚠️ Report is 6 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next   #10001      +/-   ##
==========================================
- Coverage   83.55%   81.70%   -1.86%     
==========================================
  Files         895      886       -9     
  Lines       62694    55986    -6708     
  Branches     7757     8683     +926     
==========================================
- Hits        52387    45746    -6641     
+ Misses      10307    10240      -67     
Flag Coverage Δ
app 74.31% <81.25%> (-4.01%) ⬇️
database 98.35% <ø> (ø)
packages/agent-runtime 98.37% <ø> (ø)
packages/context-engine 93.79% <ø> (ø)
packages/electron-server-ipc 93.76% <ø> (ø)
packages/file-loaders 92.21% <ø> (ø)
packages/model-bank 100.00% <ø> (ø)
packages/model-runtime 92.19% <ø> (ø)
packages/prompts 77.29% <ø> (ø)
packages/python-interpreter 96.50% <ø> (ø)
packages/utils 94.39% <ø> (-0.12%) ⬇️
packages/web-crawler 96.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 73.46% <84.00%> (-0.49%) ⬇️
Services 55.98% <37.50%> (+<0.01%) ⬆️
Server 77.07% <ø> (-0.11%) ⬇️
Libs 35.97% <ø> (ø)
Utils 83.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 68 to 72
{showRegion ? (
<Select
onChange={(region) => {
setConfig('bedrock', { region });
setConfig('bedrock', { keyVaults: { region } });
}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve existing Bedrock credentials when updating single field

Each Bedrock input calls updateAiProviderConfig with a keyVaults object containing only the changed property (accessKeyId, secretAccessKey, sessionToken, or region). The backend’s AiProviderModel.updateConfig replaces the entire stored keyVaults with the provided value rather than merging it, so typing in one field wipes any previously entered credentials. A user who enters access key and then secret key will end up persisting only the latter, making it impossible to save a complete Bedrock configuration. Consider reading the current vault values and sending a merged object (similar to useApiKey) before calling the update function.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚀 Desktop App Build Completed!

Version: 0.0.0-nightly.pr10001.8047
Build Time: 2025-11-03T06:41:26.743Z

📦 View All Build Artifacts

Build Artifacts

Platform File Size
macOS (Apple Silicon) LobeHub-Nightly-0.0.0-nightly.pr10001.8047-arm64.dmg 182.14 MB
macOS (Intel) LobeHub-Nightly-0.0.0-nightly.pr10001.8047-x64.dmg 188.59 MB
Windows LobeHub-Nightly-0.0.0-nightly.pr10001.8047-setup.exe 159.11 MB
Linux LobeHub-Nightly-0.0.0-nightly.pr10001.8047.AppImage 224.78 MB

Warning

Note: This is a temporary build for testing purposes only.

@arvinxx arvinxx merged commit 4ee4590 into next Nov 3, 2025
52 of 53 checks passed
@arvinxx arvinxx deleted the refactor/remove-deperated-code branch November 3, 2025 05:14
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Nov 3, 2025
## [Version&nbsp;2.0.0-next.16](v2.0.0-next.15...v2.0.0-next.16)
<sup>Released on **2025-11-03**</sup>

#### ♻ Code Refactoring

- **misc**: Remove deperated code.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Remove deperated code, closes [#10001](#10001) ([4ee4590](4ee4590))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 2.0.0-next.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

JamieStivala pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Nov 14, 2025
## [Version&nbsp;1.136.0](v1.135.3...v1.136.0)
<sup>Released on **2025-11-14**</sup>

#### ♻ Code Refactoring

- **misc**: Add settings (jsonb) column to `ai_models` table, edge to node runtime, enhance message router with service layer and comprehensive tests, fix thread display, Migrating Firecrawl to v2, refactor chat message model to speed up, refactor message create name, refactor services to a more clean structure, refactor trpc request to use zod schema, remove `NEXT_PUBLIC_SERVICE_MODE` env and use server by default, remove azure-ad auth provider, remove client service, remove dalle builtin plugin, remove deperated code, remove llm page, use react-router-dom change /chat page to spa mode.

#### ✨ Features

- **image**: Image model show price.
- **misc**: 2.0 next baseline, 2.0 next init, Add folder creation UI and clean up debug code, Add GPT-5.1 models, Create Pages in Knowledge Base, display assistant message in group, refactor to use agent runtime as the generation core and support branch mode, support install sreamable http mcp server on web, support tool invention, try 2.0 next, upgrade to Next 16.

#### 🐛 Bug Fixes

- **AssistantStore**: Add missing identifier parameter.
- **database**: Fix deleteMessagesBySession incorrectly deleting all messages.
- **TokenUsage**: Prevent animation when toggling between token and credit display.
- **misc**: Abnormal animation of tokens, don't include runtimeProvider in JWT for non-image operations, filter out reasoning fields from messages in ChatCompletion API, fix image prompt form, fix mcp server return image error, fix missing messages when finish runtime, fix oidc accountId mismatch, fix oidc auth timeout issue on the desktop, fix reasoning issue with claude and Response API thinking, fix regex ReDoS, fix send message, Hide marketplace link from Plugin List when market disabled, model name display in the assistant panel disappears, OIDC error when connecting to self-host instance, only include input_fidelity parameter for gpt-image-1., should install new version after quit this instance, update lost i18n files.

#### 💄 Styles

- **misc**: Add new bedrock model support, add padding to TopicList component, add pricing info for Azure GPT-5 series models, add sorting functionality for disabled models and model providers with tooltip support, fix approving render and improve Conversation style, improve built-in client OIDC user flow, improve lab style, improve oidc layout style, refactor and support move locale file intervention, smoothed model descriptions in ko-KR locales, Update ERNIE-5.0-Thinking-Preview model, update i18n, update i18n, update i18n, update i18n.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Add settings (jsonb) column to `ai_models` table, closes [lobehub#10042](https://github.com/jaworldwideorg/OneJA-Bot/issues/10042) ([7e1dd02](7e1dd02))
* **misc**: Edge to node runtime, closes [lobehub#10149](https://github.com/jaworldwideorg/OneJA-Bot/issues/10149) ([2f4c25d](2f4c25d))
* **misc**: Enhance message router with service layer and comprehensive tests, closes [lobehub#10056](https://github.com/jaworldwideorg/OneJA-Bot/issues/10056) ([62110e0](62110e0))
* **misc**: Fix thread display, closes [lobehub#10153](https://github.com/jaworldwideorg/OneJA-Bot/issues/10153) ([8fda83e](8fda83e))
* **misc**: Migrating Firecrawl to v2, closes [lobehub#9850](https://github.com/jaworldwideorg/OneJA-Bot/issues/9850) ([efb4c22](efb4c22))
* **misc**: Refactor chat message model to speed up, closes [lobehub#10053](https://github.com/jaworldwideorg/OneJA-Bot/issues/10053) ([035994f](035994f))
* **misc**: Refactor message create name, closes [lobehub#10074](https://github.com/jaworldwideorg/OneJA-Bot/issues/10074) ([08ec29f](08ec29f))
* **misc**: Refactor services to a more clean structure, closes [lobehub#10050](https://github.com/jaworldwideorg/OneJA-Bot/issues/10050) ([de61dfa](de61dfa))
* **misc**: Refactor trpc request to use zod schema, closes [lobehub#10016](https://github.com/jaworldwideorg/OneJA-Bot/issues/10016) ([1a84f2c](1a84f2c))
* **misc**: Remove `NEXT_PUBLIC_SERVICE_MODE` env and use server by default, closes [lobehub#10017](https://github.com/jaworldwideorg/OneJA-Bot/issues/10017) ([f2ab2fc](f2ab2fc))
* **misc**: Remove azure-ad auth provider, closes [lobehub#9942](https://github.com/jaworldwideorg/OneJA-Bot/issues/9942) ([103c4d7](103c4d7))
* **misc**: Remove client service, closes [lobehub#9991](https://github.com/jaworldwideorg/OneJA-Bot/issues/9991) ([9137dba](9137dba))
* **misc**: Remove dalle builtin plugin, closes [lobehub#9952](https://github.com/jaworldwideorg/OneJA-Bot/issues/9952) ([2d4d70a](2d4d70a))
* **misc**: Remove deperated code, closes [lobehub#10001](https://github.com/jaworldwideorg/OneJA-Bot/issues/10001) ([4ee4590](4ee4590))
* **misc**: Remove llm page, closes [lobehub#9940](https://github.com/jaworldwideorg/OneJA-Bot/issues/9940) ([6ec01a3](6ec01a3))
* **misc**: Use react-router-dom change /chat page to spa mode, closes [lobehub#10077](https://github.com/jaworldwideorg/OneJA-Bot/issues/10077) ([9154606](9154606))

#### What's improved

* **image**: Image model show price, closes [lobehub#10198](https://github.com/jaworldwideorg/OneJA-Bot/issues/10198) ([b87e0e4](b87e0e4))
* **misc**: 2.0 next baseline ([8c57dfd](8c57dfd))
* **misc**: 2.0 next init ([26daac5](26daac5))
* **misc**: Add folder creation UI and clean up debug code ([d5ecd0a](d5ecd0a))
* **misc**: Add GPT-5.1 models, closes [lobehub#10206](https://github.com/jaworldwideorg/OneJA-Bot/issues/10206) ([afd3a47](afd3a47))
* **misc**: Create Pages in Knowledge Base, closes [lobehub#9895](https://github.com/jaworldwideorg/OneJA-Bot/issues/9895) ([f46edeb](f46edeb))
* **misc**: Display assistant message in group, closes [lobehub#9941](https://github.com/jaworldwideorg/OneJA-Bot/issues/9941) ([59b6ac3](59b6ac3))
* **misc**: Refactor to use agent runtime as the generation core and support branch mode, closes [lobehub#10080](https://github.com/jaworldwideorg/OneJA-Bot/issues/10080) ([b95e741](b95e741))
* **misc**: Support install sreamable http mcp server on web, closes [lobehub#10044](https://github.com/jaworldwideorg/OneJA-Bot/issues/10044) [lobehub#9916](https://github.com/jaworldwideorg/OneJA-Bot/issues/9916) ([85454c5](85454c5))
* **misc**: Support tool invention, closes [lobehub#10182](https://github.com/jaworldwideorg/OneJA-Bot/issues/10182) ([4dca708](4dca708))
* **misc**: Try 2.0 next ([e0af4e6](e0af4e6))
* **misc**: Upgrade to Next 16, closes [lobehub#9851](https://github.com/jaworldwideorg/OneJA-Bot/issues/9851) ([abb71ec](abb71ec))

#### What's fixed

* **AssistantStore**: Add missing identifier parameter, closes [lobehub#9948](https://github.com/jaworldwideorg/OneJA-Bot/issues/9948) ([2e40855](2e40855))
* **database**: Fix deleteMessagesBySession incorrectly deleting all messages, closes [lobehub#10110](https://github.com/jaworldwideorg/OneJA-Bot/issues/10110) ([1d7f67d](1d7f67d))
* **TokenUsage**: Prevent animation when toggling between token and credit display, closes [lobehub#10098](https://github.com/jaworldwideorg/OneJA-Bot/issues/10098) ([f20a910](f20a910))
* **misc**: Abnormal animation of tokens, closes [lobehub#10106](https://github.com/jaworldwideorg/OneJA-Bot/issues/10106) ([129df7b](129df7b))
* **misc**: Don't include runtimeProvider in JWT for non-image operations, closes [lobehub#9959](https://github.com/jaworldwideorg/OneJA-Bot/issues/9959) [lobehub#9569](https://github.com/jaworldwideorg/OneJA-Bot/issues/9569) ([b8f25de](b8f25de))
* **misc**: Filter out reasoning fields from messages in ChatCompletion API, closes [lobehub#10203](https://github.com/jaworldwideorg/OneJA-Bot/issues/10203) [lobehub#10193](https://github.com/jaworldwideorg/OneJA-Bot/issues/10193) ([5f28b2c](5f28b2c))
* **misc**: Fix image prompt form, closes [lobehub#9995](https://github.com/jaworldwideorg/OneJA-Bot/issues/9995) ([799e6fd](799e6fd))
* **misc**: Fix mcp server return image error, closes [lobehub#10113](https://github.com/jaworldwideorg/OneJA-Bot/issues/10113) ([e5640d4](e5640d4))
* **misc**: Fix missing messages when finish runtime, closes [lobehub#10138](https://github.com/jaworldwideorg/OneJA-Bot/issues/10138) ([b94d477](b94d477))
* **misc**: Fix oidc accountId mismatch, closes [lobehub#10058](https://github.com/jaworldwideorg/OneJA-Bot/issues/10058) ([0692ba7](0692ba7))
* **misc**: Fix oidc auth timeout issue on the desktop, closes [lobehub#10025](https://github.com/jaworldwideorg/OneJA-Bot/issues/10025) ([20666db](20666db))
* **misc**: Fix reasoning issue with claude and Response API thinking, closes [lobehub#10147](https://github.com/jaworldwideorg/OneJA-Bot/issues/10147) ([cf6bd53](cf6bd53))
* **misc**: Fix regex ReDoS, closes [lobehub#10012](https://github.com/jaworldwideorg/OneJA-Bot/issues/10012) ([1d8d5cd](1d8d5cd))
* **misc**: Fix send message, closes [lobehub#10041](https://github.com/jaworldwideorg/OneJA-Bot/issues/10041) [lobehub#9984](https://github.com/jaworldwideorg/OneJA-Bot/issues/9984) ([7cca60f](7cca60f))
* **misc**: Hide marketplace link from Plugin List when market disabled, closes [lobehub#9929](https://github.com/jaworldwideorg/OneJA-Bot/issues/9929) ([e303979](e303979))
* **misc**: Model name display in the assistant panel disappears, closes [lobehub#9830](https://github.com/jaworldwideorg/OneJA-Bot/issues/9830) ([54f4e18](54f4e18))
* **misc**: OIDC error when connecting to self-host instance, closes [lobehub#9916](https://github.com/jaworldwideorg/OneJA-Bot/issues/9916) ([7a2ca19](7a2ca19))
* **misc**: Only include input_fidelity parameter for gpt-image-1., closes [lobehub#9920](https://github.com/jaworldwideorg/OneJA-Bot/issues/9920) ([65dbc63](65dbc63))
* **misc**: Should install new version after quit this instance, closes [lobehub#10064](https://github.com/jaworldwideorg/OneJA-Bot/issues/10064) ([9ab77b2](9ab77b2))
* **misc**: Update lost i18n files, closes [lobehub#10179](https://github.com/jaworldwideorg/OneJA-Bot/issues/10179) ([b69c7ff](b69c7ff))

#### Styles

* **misc**: Add new bedrock model support, closes [lobehub#9826](https://github.com/jaworldwideorg/OneJA-Bot/issues/9826) ([1b8a981](1b8a981))
* **misc**: Add padding to TopicList component, closes [lobehub#9994](https://github.com/jaworldwideorg/OneJA-Bot/issues/9994) ([c1e7381](c1e7381))
* **misc**: Add pricing info for Azure GPT-5 series models, closes [lobehub#9833](https://github.com/jaworldwideorg/OneJA-Bot/issues/9833) ([39a80c5](39a80c5))
* **misc**: Add sorting functionality for disabled models and model providers with tooltip support, closes [lobehub#10000](https://github.com/jaworldwideorg/OneJA-Bot/issues/10000) ([68e98b1](68e98b1))
* **misc**: Fix approving render and improve Conversation style, closes [lobehub#10210](https://github.com/jaworldwideorg/OneJA-Bot/issues/10210) ([841b7f1](841b7f1))
* **misc**: Improve built-in client OIDC user flow, closes [lobehub#10020](https://github.com/jaworldwideorg/OneJA-Bot/issues/10020) ([80202ed](80202ed))
* **misc**: Improve lab style, closes [lobehub#10040](https://github.com/jaworldwideorg/OneJA-Bot/issues/10040) ([bbf1c0b](bbf1c0b))
* **misc**: Improve oidc layout style, closes [lobehub#10023](https://github.com/jaworldwideorg/OneJA-Bot/issues/10023) ([5008be7](5008be7))
* **misc**: Refactor and support move locale file intervention, closes [lobehub#10213](https://github.com/jaworldwideorg/OneJA-Bot/issues/10213) ([63cac81](63cac81))
* **misc**: Smoothed model descriptions in ko-KR locales, closes [lobehub#9998](https://github.com/jaworldwideorg/OneJA-Bot/issues/9998) ([fde1d8b](fde1d8b))
* **misc**: Update ERNIE-5.0-Thinking-Preview model, closes [lobehub#10196](https://github.com/jaworldwideorg/OneJA-Bot/issues/10196) ([89f3eed](89f3eed))
* **misc**: Update i18n, closes [lobehub#10116](https://github.com/jaworldwideorg/OneJA-Bot/issues/10116) ([766772e](766772e))
* **misc**: Update i18n, closes [lobehub#10100](https://github.com/jaworldwideorg/OneJA-Bot/issues/10100) ([deb6b5e](deb6b5e))
* **misc**: Update i18n, closes [lobehub#9958](https://github.com/jaworldwideorg/OneJA-Bot/issues/9958) ([f49996c](f49996c))
* **misc**: Update i18n, closes [lobehub#9944](https://github.com/jaworldwideorg/OneJA-Bot/issues/9944) ([3a6468f](3a6468f))

</details>

#### 💥 BREAKING CHANGES

* **misc**: starting V2
* **misc**: starting V2

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Model Provider Model provider related released on @next size:XXL This PR changes 1000+ lines, ignoring generated files. trigger:build-desktop Trigger Desktop build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants