♻️ refactor: remove deperated code #10001
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @arvinxx, your pull request is larger than the review limit of 150000 diff characters
dosubot
bot
added
the
size:XXL
|
👍 @arvinxx Thank you for raising your pull request and contributing to our Community |
|
There is too much information in the pull request to test. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #10001 +/- ##
==========================================
- Coverage 83.55% 81.70% -1.86%
==========================================
Files 895 886 -9
Lines 62694 55986 -6708
Branches 7757 8683 +926
==========================================
- Hits 52387 45746 -6641
+ Misses 10307 10240 -67
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {showRegion ? ( | ||
| <Select | ||
| onChange={(region) => { | ||
| setConfig('bedrock', { region }); | ||
| setConfig('bedrock', { keyVaults: { region } }); | ||
| }} |
There was a problem hiding this comment.
Each Bedrock input calls updateAiProviderConfig with a keyVaults object containing only the changed property (accessKeyId, secretAccessKey, sessionToken, or region). The backend’s AiProviderModel.updateConfig replaces the entire stored keyVaults with the provided value rather than merging it, so typing in one field wipes any previously entered credentials. A user who enters access key and then secret key will end up persisting only the latter, making it impossible to save a complete Bedrock configuration. Consider reading the current vault values and sending a merged object (similar to useApiKey) before calling the update function.
Useful? React with 👍 / 👎.
🚀 Desktop App Build Completed!Version: Build Artifacts
Warning Note: This is a temporary build for testing purposes only. |
|
❤️ Great PR @arvinxx ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
## [Version 2.0.0-next.16](v2.0.0-next.15...v2.0.0-next.16) <sup>Released on **2025-11-03**</sup> #### ♻ Code Refactoring - **misc**: Remove deperated code. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Remove deperated code, closes [#10001](#10001) ([4ee4590](4ee4590)) </details> <div align="right"> [](#readme-top) </div>
|
🎉 This PR is included in version 2.0.0-next.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information