Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SELF-438: Radio Buttons #532

Merged
merged 1 commit into from
Aug 6, 2024
Merged

SELF-438: Radio Buttons #532

merged 1 commit into from
Aug 6, 2024

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Aug 6, 2024 •
edited by jira bot
Loading

JIRA

Description

  • Consolidates radio button variants and improves some bugs known with them
  • Adds support for icons and Chips

Screenshots

image
image
image
image
image
image
image
image

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

@guardrails GuardRails
Copy link

guardrails bot commented Aug 6, 2024 •
edited
Loading

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1

More info on how to fix Vulnerable Libraries in JavaScript.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-438/radio-buttons branch from 2696db3 to 52c6468 Compare August 6, 2024 12:49
@NateWaldschmidt NateWaldschmidt force-pushed the SELF-438/radio-buttons branch from 52c6468 to 7859ac6 Compare August 6, 2024 12:58
@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review August 6, 2024 13:10
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner August 6, 2024 13:10
juanfriss
juanfriss approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@juanfriss juanfriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they do look nicer!

@NateWaldschmidt NateWaldschmidt merged commit 888e443 into main Aug 6, 2024
3 of 4 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-438/radio-buttons branch August 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgelob jorgelob jorgelob approved these changes

@juanfriss juanfriss juanfriss approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NateWaldschmidt @juanfriss @jorgelob