fix: radio attribute typing

lob · Aug 6, 2024 · 222fcd3 · 222fcd3
1 parent 888e443
commit 222fcd3
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## v2.0.88
+
+- Fixes typing of `-attribute` props to allow `data-` attributes on `RadioButton` and `RadioButtonGroup`
+
 ## v2.0.87
 
 - Bug fixes and improvements of the `RadioButton` component

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lob/ui-components",
-  "version": "2.0.87",
+  "version": "2.0.88",
   "engines": {
     "node": ">=20.2.0",
     "npm": ">=10.2.0"

diff --git a/src/components/RadioButton/RadioButton.vue b/src/components/RadioButton/RadioButton.vue
@@ -49,10 +49,10 @@ withDefaults(
     helperText?: string;
     icon?: IconName;
     id: string;
-    inputAttributes?: InputHTMLAttributes;
+    inputAttributes?: InputHTMLAttributes & Record<string, unknown>;
     label?: string;
-    labelContainerAttributes?: HTMLAttributes;
-    labelAttributes?: LabelHTMLAttributes;
+    labelContainerAttributes?: HTMLAttributes & Record<string, unknown>;
+    labelAttributes?: LabelHTMLAttributes & Record<string, unknown>;
     loading?: boolean;
     name: string;
     readonly?: boolean;
@@ -132,7 +132,7 @@ $disabled-radio: '.uic-radio-button-input:disabled';
     }
 
     .variant-outlined & {
-      @apply px-6 py-3;
+      @apply px-4 p-3;
       @apply min-w-[16rem];
     }
 

diff --git a/src/components/RadioButton/RadioButtonGroup.vue b/src/components/RadioButton/RadioButtonGroup.vue
@@ -38,7 +38,7 @@ withDefaults(
     disabled?: boolean;
     spaceEvenly?: boolean;
     label?: string;
-    labelAttributes?: LabelHTMLAttributes;
+    labelAttributes?: LabelHTMLAttributes & Record<string, unknown>;
     /** Simply adds an asterisk to the `legend`, does not enforce required on `RadioButton`s. */
     required?: boolean;
     hideLabel?: boolean;