Integrate LLVM at 41f65666f6378bba7266be7c662c70074f04ed75 #4358
Conversation
|
@Yu-Zhewen thanks for this change. You probably need to integrate changes in #4311 by @justin-ngo-arm |
Still carrying two reverts as #22366. New cherry-picks: - [MLIR] Revamp RegionBranchOpInterface (llvm/llvm-project@41f6566) - Corresponding torch-mlir fix (llvm/torch-mlir#4358) Also, IREE fixes on `RegionBranchPoint` and `RegionSuccessor`. ci-extra: test_torch, windows_x64_msvc Signed-off-by: Yu-Zhewen <[email protected]>
Thanks, @sahas3. We also need to address the deprecation from llvm/llvm-project#164649. I already have a fix, but it’s around 10k lines of changes (iree-org@553f323). Would you be okay if I revert llvm/llvm-project#164649 in this PR and then submit a separate PR for the larger fix? |
@Yu-Zhewen maybe we leave the patch here and ask the torch-mlir integrator to pick this up. We already cherry-pick the change in IREE and it works well. The last bump is 2 months ago, and I think it not IREE build gardener's responsibility to maintain torch-mlir llvm state. (cc @MaheshRavishankar ) |
Signed-off-by: Yu-Zhewen <[email protected]>
Signed-off-by: Yu-Zhewen <[email protected]>
Signed-off-by: Yu-Zhewen <[email protected]>
…o enums Context: TOSA's rounding mode, nan propagation, and resize mode have been updated from string attributes to enums. This commit updates the Torch to TOSA path to align with those changes. Signed-off-by: Justin Ngo <[email protected]>
Signed-off-by: Yu-Zhewen <[email protected]>
Signed-off-by: Yu-Zhewen <[email protected]>
Yu-Zhewen
force-pushed
the
users/Yu-Zhewen/integrate-llvm-41f6566
branch
from
1da0692 to
9b579d8
Compare
| [submodule "externals/llvm-project"] | ||
| path = externals/llvm-project | ||
| url = https://github.com/llvm/llvm-project.git | ||
| url = https://github.com/iree-org/llvm-project.git |
There was a problem hiding this comment.
I don't have commit access to llvm, so doing the revert on a fork. Will change it back in the follow-up PR
Carries cherry-pick iree-org/torch-mlir@42dff72 (WIP PR llvm/torch-mlir#4358) Fixes ONNX failure related to i1 tensors. --------- Signed-off-by: Ian Wood <[email protected]>
5 participants
Bump LLVM to llvm/llvm-project@41f6566
Bump StableHLO to openxla/stablehlo@4c0d484
Revert llvm/llvm-project#164649, will address in a follow-up PR.
Fix RegionBranchPoint/RegionSuccessor as llvm/llvm-project#165429
Fix populateExpansionPatterns as llvm/llvm-project#151153
Integrate #4311