-
Notifications
You must be signed in to change notification settings - Fork 557
Add Windows build workflow in the CI. #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e2f888
to
6c22f83
Compare
Hi @sjarus and @justin-ngo-arm, I had to modify the TOSA filecheck tests in this PR as looks like the emission order of back to back |
Thanks! @justin-ngo-arm maybe we want to relax the checks to support such non determinism here ? Since we already have more robust functional testing , ordering restrictions in LIT tests are probably unnecessary. |
Sounds good to me. I can use |
LG on sparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oking the TOSA LIT changes.
Build times so far are really good. Consistently getting high cache hit rates. https://github.com/llvm/torch-mlir/actions/workflows/ci_windows.yml Cold cache: 2 hours This new workflow did miss a downstream Windows issue though: #4085. I'll see if I can find what is different about the build (e.g. compiler flags tested, compiler version in the workflow, differences between upstream and downstream build environment). |
torch-nightly
since python based tests are disabled. My understanding is that without the python based tests there's no need to run against thestable
version too. If that's not the case, will enablestable
as well. Tested that bothnightly
andstable
versions work fine: https://github.com/sahas3/torch-mlir/actions/runs/13477124004