Generalize the PyTorch avg_pool linalg lowering algorithm for the case where count_include_pad = false. #4010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2025 17:24
…e where count_include_pad = false.
sahas3
reviewed
Feb 14, 2025
sahas3
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Thanks for making the changes @ivangarcia44. Looks much cleaner now. Some minor comments. I'll leave the approval to other reviewers.
|
Hi @rsuderman @AmosLewis , would it be ok to merge this change? |
|
Closing merge request. Will create a new one to avoid the merge issue. |
|
@AmosLewis @rsuderman @sahas3 @dixinzhou Please review the new merge request here: #4035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the avg_pool2d PyTorch operation supports the cases where count_include_pad is true and false, but the avg_pool1d and avg_pool3d only the true case is supported (which is simpler).
The count_include_pad = false support for avg_pool2d was added by @AmosLewis in this change (reviewed by @rsuderman and @nirvedhmeshram) : #3235
In this change I generalized the logic added above. I also did some refactoring to the original code to reduce the size of the functions and to avoid redundancy when possible.
@sahas3 @dixinzhou @rafaelubal