Skip to content

Pooling.cpp changes causes windows builds to fail downstream in iree-org/iree #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renxida opened this issue Mar 10, 2025 · 2 comments · Fixed by #4086
Closed

Pooling.cpp changes causes windows builds to fail downstream in iree-org/iree #4085

renxida opened this issue Mar 10, 2025 · 2 comments · Fixed by #4086

Comments

@renxida
Copy link
Collaborator

renxida commented Mar 10, 2025

Recent changes causes windows (and only windows) builds to fail downstream in iree. See logs at: https://github.com/iree-org/iree/actions/runs/13757267783/job/38466645214#step:14:10632

I think it has something to do with

Why I think this is caused by a torch-mlir change

I am specifically seeing these errors:

D:\a\iree\iree\c\third_party\torch-mlir\lib\Conversion\TorchToLinalg\Pooling.cpp(1098): error C2131: expression did not evaluate to a constant
D:\a\iree\iree\c\third_party\torch-mlir\lib\Conversion\TorchToLinalg\Pooling.cpp(1099): error C2039: 'getDivisorOverride': is not a member of 'mlir::torch::Torch::AtenAvgPool1dOp'

Windows builds were succeeding up to 0307 but failed for 0308, 0309, 0310.

Timeframe lines up with a recent torch-mlir bump in iree.

Why I think this is caused by #4035

The error message mentions Pooling.cpp in TorchToLinalg

@ScottTodd
Copy link
Member

I have a fix, will push a PR shortly. Not yet sure why the new CI missed this though.

@ScottTodd
Copy link
Member

Fix is up for review at #4086.

I can repro this in my local (downstream) IREE build. I can't repro this on the same system yet in torch-mlir standalone. Checking how the compiler flags differ between projects.

ScottTodd added a commit to iree-org/iree that referenced this issue Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants