Skip to content

Add support for UAV Counters #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

V-FEXrt
Copy link

@V-FEXrt V-FEXrt commented Apr 23, 2025

This PR add support for HLSL code that updates the counter on a UAV Resource and reading it back to check against.

@V-FEXrt V-FEXrt changed the title Ass support for UAV Counters Add support for UAV Counters Apr 23, 2025
Copy link
Member

@hekota hekota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -89,6 +89,14 @@ static DXGI_FORMAT getRawDXFormat(Resource &R) {
return DXGI_FORMAT_UNKNOWN;
}

static uint32_t getUAVBufferSize(Resource &R) {
Copy link

@alsepkow alsepkow May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint32_t

nit: Use size_t instead? Same below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is a pseudo size value for Resource R and the type of R.size() is uint32_t and imo it makes the most sense to keep them aligned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants