[Fortran/gfortran] Better handling of unsupported gfortran options #250
+2,939
−3,068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of tests use gfortran-specific options which are either not supported in flang, or for which a suitable equivalent has not yet been enabled. These options used to be filtered out in CMakeLists.txt when configuring the test suite. This has been moved to the test configuration script to allow for more flexibility (since cmake is a terrible language in which to do anything even remotely sophisticated). Doing this has allowed us to perform wildcard matches for options that expose gfortran's internal structure which is obviously not relevant for flang. This means that in the future, we do not have to constantly update the filter with these options. We can now also distinguish between the option name and its value, so we can filter simply based on the option spelling. The test configuration files have been regenerated after this change. Some tests fail with this updated configuration and they have been disabled.
tarunprabhu
requested review from
tblah,
kiranchandramohan,
kkwli,
jeanPerier,
AlexisPerry,
luporl and
ylzsx
tblah
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tests use gfortran-specific options which are either not supported in flang, or for which a suitable equivalent has not yet been enabled. These options used to be filtered out in CMakeLists.txt when configuring the test suite. This has been moved to the test configuration script to allow for more flexibility (since cmake is a terrible language in which to do anything even remotely sophisticated).
Doing this has allowed us to perform wildcard matches for options that expose gfortran's internal structure which is obviously not relevant for flang. In the future, we do not have to constantly update the filter with these options. We can also distinguish between the option name and its value, so we can filter simply based on the option spelling.
The test configuration files have been regenerated after this change. Some tests fail with this updated configuration and they have been disabled.
Notes for reviewers:
update-test-config.py: