Skip to content

[DataLayout] Add isNullPointerAllZeroes #165314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DataLayout] Add isNullPointerAllZeroes #165314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107930b
[DataLayout] Add isNullPointerAllZeroes
ro-i Oct 27, 2025
28f70ab
always return true for now
ro-i Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/include/llvm/IR/DataLayout.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,10 @@ class DataLayout {
PS.HasExternalState;
}

/// Returns if the null pointer for this address space has an all-zero bit
/// representation.
bool isNullPointerAllZeroes(unsigned AddrSpace) const { return true; }

/// Returns whether this address space has an "unstable" pointer
/// representation. The bitwise pattern of such pointers is allowed to change
/// in a target-specific way. For example, this could be used for copying
Expand Down
9 changes: 9 additions & 0 deletions llvm/unittests/IR/DataLayoutTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,15 @@ TEST(DataLayout, NonIntegralHelpers) {
}
}

TEST(DataLayoutTest, IsNullPointerAllZeroes) {
EXPECT_TRUE(DataLayout("").isNullPointerAllZeroes(0));
EXPECT_TRUE(DataLayout("").isNullPointerAllZeroes(1));
EXPECT_TRUE(DataLayout("p:32:32").isNullPointerAllZeroes(0));
EXPECT_TRUE(DataLayout("p:32:32").isNullPointerAllZeroes(1));
EXPECT_TRUE(DataLayout("p:64:64").isNullPointerAllZeroes(0));
EXPECT_TRUE(DataLayout("p:64:64").isNullPointerAllZeroes(1));
}

TEST(DataLayoutTest, CopyAssignmentInvalidatesStructLayout) {
DataLayout DL1 = cantFail(DataLayout::parse("p:32:32"));
DataLayout DL2 = cantFail(DataLayout::parse("p:64:64"));
Expand Down
Loading