Skip to content

[Win][X86]Fix issue where _fltused reference is incorrectly issued for vector floating point operations #146792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −2
Open

[Win][X86]Fix issue where _fltused reference is incorrectly issued for vector floating point operations #146792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
774d9c9
Only reference _fltused for floating point, not vectors of floating p…
AdamGlass Jun 15, 2025
d6c6766
address test feedback
AdamGlass Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Target/X86/X86AsmPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,11 +1002,11 @@ static bool usesMSVCFloatingPoint(const Triple &TT, const Module &M) {

for (const Function &F : M) {
for (const Instruction &I : instructions(F)) {
if (I.getType()->isFPOrFPVectorTy())
if (I.getType()->isFloatingPointTy())
return true;

for (const auto &Op : I.operands()) {
if (Op->getType()->isFPOrFPVectorTy())
if (Op->getType()->isFloatingPointTy())
return true;
}
}
Expand Down
29 changes: 29 additions & 0 deletions llvm/test/CodeGen/X86/fltused_vec.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
; The purpose of this test to verify that the fltused symbol is
; not emitted when purely vector floating point operations are used on Windows.

; RUN: llc < %s -mtriple i686-pc-win32 | FileCheck %s
; RUN: llc < %s -mtriple x86_64-pc-win32 | FileCheck %s

@foo = external dso_local global [4 x float], align 16

; Function Attrs: noinline nounwind optnone sspstrong uwtable
define dso_local <4 x float> @func() #0 {
entry:
%__p.addr.i = alloca ptr, align 8
%vector1 = alloca <4 x float>, align 16
store ptr @foo, ptr %__p.addr.i, align 8
%0 = load ptr, ptr %__p.addr.i, align 8
%1 = load <4 x float>, ptr %0, align 16
store <4 x float> %1, ptr %vector1, align 16
%2 = load <4 x float>, ptr %vector1, align 16
ret <4 x float> %2
}

define <4 x float> @mul_vectors(<4 x float> %a, <4 x float> %b) {
entry:
%result = fmul <4 x float> %a, %b
ret <4 x float> %result
}

; _fltused is determined at a module level
; CHECK-NOT: .globl {{_?}}_fltused