[libc++][NFC] Add reminder to remove _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER macro #127070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TER macro `__cpp_explicit_this_parameter` has been set in LLVM20 // llvm#107451
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Hristo Hristov (H-G-Hristov) Changes
Full diff: https://github.com/llvm/llvm-project/pull/127070.diff 1 Files Affected:
diff --git a/libcxx/include/__config b/libcxx/include/__config
index ca6aade34107b..5c8c72fce5921 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -1198,6 +1198,8 @@ typedef __char32_t char32_t;
# define _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK
# endif
+// TODO(LLVM 22): Remove this macro once LLVM19 support ends. __cpp_explicit_this_parameter has been set in LLVM20
+// https://github.com/llvm/llvm-project/pull/107451
// Clang-18 has support for deducing this, but it does not set the FTM.
# if defined(__cpp_explicit_this_parameter) || (defined(_LIBCPP_CLANG_VER) && _LIBCPP_CLANG_VER >= 1800)
# define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER 1
|
mordante
approved these changes
Feb 13, 2025
libcxx/include/__config
Outdated
| @@ -1198,6 +1198,8 @@ typedef __char32_t char32_t; | |||
| # define _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK | |||
| # endif | |||
|
|
|||
| // TODO(LLVM 22): Remove this macro once LLVM19 support ends. __cpp_explicit_this_parameter has been set in LLVM20 | |||
| // https://github.com/llvm/llvm-project/pull/107451 | |||
There was a problem hiding this comment.
I don't mind the link, but I don't think it's really required when doing similar patches in the future.
Zingam
reviewed
Feb 14, 2025
Zingam
reviewed
Feb 14, 2025
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
…TER macro (llvm#127070) `__cpp_explicit_this_parameter` has been set in LLVM20 llvm#107451 / llvm@72e58e0 --------- Co-authored-by: Hristo Hristov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__cpp_explicit_this_parameterhas been set in LLVM20#107451 / 72e58e0