[CIR] Add syncscope support for atomic load operations #1958
+125
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiang1997
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
jiang1997
force-pushed
the
fix-#1868
branch
2 times, most recently
from
5b25f33 to
af464b6
Compare
| @@ -1,7 +1,5 @@ | |||
| // RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -I%S/../Inputs -mconstructor-aliases -fclangir -fclangir-lifetime-check="history=all" -fclangir-skip-system-headers -clangir-verify-diagnostics -emit-cir %s -o %t.cir | |||
|
|
|||
| // XFAIL: * | |||
There was a problem hiding this comment.
Let's address this separately, because it's not failing in all platforms, I'll merge the PR regardless if the only thing failing is related to this test (no worries).
| // RUN: %clang_cc1 -x c -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir | ||
| // RUN: FileCheck --input-file=%t.cir %s | ||
|
|
||
| // CHECK-LABEL: @scoped_load_thread |
There was a problem hiding this comment.
- We also need to check for LLVM output. Please rename
CHECKtoCIRand add both aLLVMand aOGCGone (seeclang/test/CIR/CodeGen/opaque.cppfor an exmple). - Change the ARM64 test for your change to check for the scope value.
- There are changes to
CIRGenAtomic.cppso maybe it's worth taking a look and changing where appropriate existing tests in:
./CodeGen/atomic-xchg-field.c
./CodeGen/atomic-thread-fence.c
./CodeGen/c11atomic.c
./CodeGen/atomic.cpp
./CodeGen/atomic-runtime.cpp
| cir::AtomicFetchKindAttr fetchAttr; | ||
| bool fetchFirst = true; | ||
| auto scopeAttr = cir::MemScopeKindAttr::get(builder.getContext(), Scope); | ||
| std::optional<cir::MemScopeKind> scopeOpt; |
There was a problem hiding this comment.
Looks like these 3 lines are not needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1868