[CIR] Add back verification of LoopOpInterface #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verification used to require a runtime type query of `ConditionOp` which is not available outside the interface package; whereas the dialect package depends on the interface package, causing a circular dependency. This commit adds a singleton interface for `ConditionOp` to break off the circular dependency, and replaces the runtime type query using the newly added interface. Tested locally with a build with shared library enabled and verified that the build succeeds.
| @@ -96,4 +96,11 @@ def LoopOpInterface : OpInterface<"LoopOpInterface", [ | |||
| }]; | |||
| } | |||
|
|
|||
| def ConditionOpInterface : OpInterface<"ConditionOpInterface", []> { | |||
There was a problem hiding this comment.
We should probably name this something more CIR specific: CIR_ConditionOpInterface? @xlauko any naming suggestions since you've been renaming a bunch?
There was a problem hiding this comment.
Yes everything in tablegen needs to be prefixed with the CIR_ so it does not create name clashes for potential users or if core decides to add ConditionOpInterface. Unfortunately tablegen does not have namespace so this is the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verification used to require a runtime type query of
ConditionOpwhich is not available outside the interface package; whereas the dialect package depends on the interface package, causing a circular dependency. This commit adds a singleton interface forConditionOpto break off the circular dependency, and replaces the runtime type query using the newly added interface.Tested locally with a build with shared library enabled and verified that the build succeeds.