[CIRGen] Convert trivial copy constructor and assignment operator calls to memcpy #1616
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it's a trivial copy-constructable, emit the cir.copy directly
There was a problem hiding this comment.
Thanks for your first PR.
Some things that need improvements here:
- Add a testcase (see others in clang/test/CIR for examples).
- Follow the coding guidelines: https://llvm.github.io/clangir/GettingStarted/coding-guideline.html
- Volatile: you need to detect whether it's volatile and add a
llvm_unrecheable("NYI")(Not Yet Implemented) for it, so later on we can incrementally add volatile support and add the appropriated testcase.
bcardosolopes
approved these changes
May 21, 2025
- pull out the logic in emitCXXConstructorCall for copy construct only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.