-
Notifications
You must be signed in to change notification settings - Fork 2
Task/rhornung67/rework lesson 04 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
artv3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! It gets participants running parallel programs sooner. I can also take a pass at removing the solution folder and moving the solution file to the same space as the exercise file after we merge this in.
I was thinking about doing that. I think it would be better to move the solution files up one level and remove the directory, since it would be easier to navigate. Also, I think we should build the solution files also so it's easier for participants to compare with their attempt. |
|
This one is good to merge. Please review if you wish. Thank you. |
|
Looks good to me, @johnbowen42 since you are presenting lesson 4 can you take a look? |
johnbowen42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merge when ready! |
Based on our meeting last week, this is what I had in mind for intro lesson 4. Note that it the README is about the same length as the original original, the work for the participants to do is similar (although it actually gives them a working version to look at), and it allows them to compare performance of sequential and OpenMP variants of the same kernel.