Skip to content

Conversation

@rchen20
Copy link
Member

@rchen20 rchen20 commented Jun 30, 2025

No description provided.

@rchen20 rchen20 requested review from artv3, johnbowen42 and kab163 June 30, 2025 22:58
RAJA::View<double, RAJA::Layout<DIM>> A_t(a_t, M, N);

RAJA::TypedRangeSegment<int> row_range(0, N);
RAJA::TypedRangeSegment<int> col_range(0, M);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the TODO part of the exercise?

RAJA::KernelPolicy<
RAJA::statement::CudaKernel<
RAJA::statement::For<1, RAJA::cuda_thread_y_loop,
RAJA::statement::For<0, RAJA::cuda_thread_x_loop,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should coordinate with @johnbowen42 to make sure we use the same policies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think that it would be useful to explain the basic differences between 'loop' and 'direct' policies. We've had issues in the past when users apply loop policies following our basic examples and see performance that is less than expected. I would recommend to not use loop policies for an introduction.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the global policies here, and part of slides could be an overview of different options. I was planning include that in my slide deck.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea.

@artv3
Copy link
Member

artv3 commented Jul 1, 2025

We need a companion readme in this PR

RAJA::KernelPolicy<
RAJA::statement::CudaKernel<
RAJA::statement::For<1, RAJA::cuda_global_size_y_loop<8>,
RAJA::statement::For<0, RAJA::cuda_global_size_x_direct<32>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we will have to explain the block sizes at the tutorial?

@artv3
Copy link
Member

artv3 commented Jul 12, 2025

I think we can close this PR, we have decided to leave this lesson out of the intro tutorial.

@artv3
Copy link
Member

artv3 commented Jul 16, 2025

No longer needed

@artv3 artv3 closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants